-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Santiago Gala <[EMAIL PROTECTED]> writes:

> Raphael Luta wrote:
<snip>

> 
> I know, we have to clean and document properly. For instance, code in the
> DiskCache exports too many things and has several redundant methods. It
> needs heavy refactoring. I would ask everybody for discipline in cleaning
> code, and testing before committing or sending patches. I.E.:

Yes.  Actually I think DiskCache should just become URLProxy or something.  It
does need Refactoring.  There is a new book out that I bought on Refactoring
from one of the GOF guys.  It is really great!  I am going to send off an e-mail
documenting the sections of Jetspeed that I think need to be reworked and parts
that should move to other projects (daemon etc should go under Turbine)....

> Try to build.sh clean; build.sh before committing, as new files are commonly
> forgotten to add to CVS
> Try to at least run Jetspeed, look at the home, login, logout, ... and see

We also need nightly builds..... Now that I have a reliable Internet connection
this might be something worth setting up......... of course this is a huge
problem.  All the ASF stuff needs nightly builds.. :(

> the Applications and the Feed process before committing.

I don't know if some of you noticed.  There is now a UnitTesting framework.
Some of this stuff is meant to make sure Jetspeed meets its contracts before you
commit.  This should be run too.
<snip>

> 
> Note: I have the habitude of putting //SGP in small patches to other
> people's code (it means Santiago Gala Perez). If you see this and have
> problems with the code, ask me.

If you use CVS web annotation... this is included too.  It would be cool to have
an Emacs mode that showed the annotation sections while you are working as
overlays :)...  hm... :)

> I know that everybody should know this, but, well, maybe somebody does not
> :-)
<snip>

Yeah... sometimes even best practices get broken :)

- -- 
Kevin A. Burton ( [EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED] )
             Cell: 408-910-6145 URL: http://relativity.yi.org

Linux.  Don't leave home without it!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.4 (GNU/Linux)
Comment: Get my public key at: http://relativity.yi.org/pgpkey.txt

iD8DBQE6EeZdAwM6xb2dfE0RAh0oAJ0VvQI4T6eoLBBAyyK8sOhoDiwPjACdHsWu
tKaTvH8FOfY22jTGd0Fhseo=
=Ggaq
-----END PGP SIGNATURE-----



Ortega Semtex nuclear bomb Ft. Meade Treasury Panama arrangements Uzi Honduras
DES kibo Saddam Hussein Soviet Mossad


--
--------------------------------------------------------------
Please read the FAQ! <http://java.apache.org/faq/>
To subscribe:        [EMAIL PROTECTED]
To unsubscribe:      [EMAIL PROTECTED]
Archives and Other:  <http://marc.theaimsgroup.com/?l=jetspeed>
Problems?:           [EMAIL PROTECTED]

Reply via email to