on 11/17/2000 4:32 PM, "Santiago Gala" <[EMAIL PROTECTED]> wrote:
> I had to patch org.apache.ecs.GenericElement.java, which plainly did not know
> how to
> convert multibyte characters back to a String.
>
> As I'm not involved in ECS, I put here the patch and I send this message to
> the ecs
> list and Jon Stevens. It is not very clean, but the principle is: never use a
> ByteArray to write characters to, since you will loose the high byte. I have
> tested
> the changes, and I have found no problem.
>
> To check for the problem, start Jetspeed, wait until feed are processed, and
> search
> "javable". There should be two channels, one in English and one in Russian.
> The
> Russian one should be filled with "?".
>
> After the patch, It should display plenty of Cyrillic characters.
Actually no, I think that you are wrong.
If you pass the correct encoding to the toString() method of a
ByteArrayOutputStream, the Javadoc clearly states that it does the
translation between bytes and characters. ECS is clearly doing this
correctly. It appears as though you are not though.
Given that people have been using ECS for quite some time and haven't
complained yet so far of I8n issues within ECS and I have heard of MANY
people using Turbine with I8N without any problems and Turbine's core
revolves around I8N (Jyve is another example of a fully I8N localized
application based 100% on top of ECS), I think that this is clearly a
problem on your end.
Also, your solution is a bad hack as you don't even wrap things in Buffered
streams nor does your toString(encoding) method actually use the encoding
parameter. Huh? You are actually removing functionality from the code.
So, I'm -1 on this patch.
thanks,
-jon
--
twice of not very much is still a lot more than not very much
--
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Archives and Other: <http://java.apache.org/main/mail.html>
Problems?: [EMAIL PROTECTED]
