[EMAIL PROTECTED] escribió:
> Santiago Gala wrote:
> >
> > I discovered a funny error while I was updating SimpleTransform.java
> >
> > This class had been changed in a way that rendered useless the disk
> > cache (possibly in the rush towards 1.3a1) This caused that the OCS
> > feeds were loaded twice, one for the cache and another one for the
> > transform. In the case of other resources, it was less of a problem.
> >
> > When I restored the cache, all the rss portlets stopped working. The OCS
> > worked perfectly, though.
> >
> > Tracing the error, I discovered that it was due to a problem with the
> > stylesheets (rss.xsl and rss-wml.xsl).
> >
> > An error in the getReader method of the JetspeedDiskCacheEntry used
> > utf-8 as the encoding, instead of the true one. When Raphaël put his
> > name there (in a comment), the "ë" caused a wrong encoding error, that
> > spoiled the Stylesheet compilation.
> >
>
> Can you explain more about this issue, because I did modify the encoding
> declared in the xml declaration, so the stylesheets were stille valid xml
> documents ?
> If I understand correctly what you say, the JetspeedDiskCacheEntry only accepts
> utf-8 encoded file, is that it ?
No. it was an error. In principle, all entries cached (in the cache directory) are
always saved and restored as utf-8 files, to avoid problems with different
encoding or character loosage).
Local urls, instead, asume the encoding given by the url protocol, or the default
encoding configured, if the url does not specify it.
The bug was that, with regards to the getReader() method, the local urls were
processed as if they were remote, i.e. utf-8 was assumed. I swapped the tests to
avoid this problem, so now the isLocal() test is done before the (getFile() ==
null) test. For a time getFile() returning null implied that the entry was local.,
because file was implied to be the cached file.This seems to be no longer true.
This kind of bad state and invariant handling is what calls for a complete
restructuring of this module. I have code, not finished and not tested. I will
branch to test it, just to be sure that I minimise problems and have freedom to
experiment for a while.
>
>
> --
> Raphaël Luta - [EMAIL PROTECTED]
> Vivendi Universal Networks - Services Manager / Paris
>
> --
> --------------------------------------------------------------
> To subscribe: [EMAIL PROTECTED]
> To unsubscribe: [EMAIL PROTECTED]
> Search: <http://www.mail-archive.com/[email protected]/>
> List Help?: [EMAIL PROTECTED]
--
--------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Search: <http://www.mail-archive.com/[email protected]/>
List Help?: [EMAIL PROTECTED]
