https://bugs.eclipse.org/bugs/show_bug.cgi?id=409801

Happy to test once it's landed, I'll keep an eye out for an update on the
bugzilla bug.  Thanks Jan!


On Mon, Jun 3, 2013 at 8:48 PM, Jan Bartel <[email protected]> wrote:

> If you could open a bugzilla for it, it would be good! And also standby
> for testing of it when ready.
>
> thanks,
> Jan
>
>
> On 4 June 2013 11:42, Craig Ching <[email protected]> wrote:
>
>> That would definitely work for me.  Do you need me to do anything?  Open
>> a defect?  Agree to test it? ;-)
>>
>> Thanks Jan, much appreciated!
>>
>>
>> On Mon, Jun 3, 2013 at 8:27 PM, Jan Bartel <[email protected]> wrote:
>>
>>> Hhm, well we could certainly implement a fallback scheme:
>>>
>>> if relative
>>>     if found relative to bundle, job done
>>>     else if found relative to jetty.home, job done
>>>     else exception
>>>
>>> WDYT?
>>>
>>> Jan
>>>
>>>
>>> On 4 June 2013 11:23, Craig Ching <[email protected]> wrote:
>>>
>>>> Right, but absolute doesn't work for me, I need it to be relative, even
>>>> relative to jetty.home is fine, but relative.
>>>>
>>>>
>>>> On Fri, May 31, 2013 at 11:35 PM, Jan Bartel <[email protected]> wrote:
>>>>
>>>>> Yes, the webdefault.xml specified in the Jetty-defaultWebXmlFilePath
>>>>> can be an absolute, external location, *or* internal to the bundle.
>>>>>
>>>>> Jan
>>>>>
>>>>>
>>>>> On 1 June 2013 00:48, Craig Ching <[email protected]> wrote:
>>>>>
>>>>>> Hi Jan,
>>>>>>
>>>>>> Thanks for the information, I had found that, but what I really
>>>>>> wanted to be able to do was have the webdefault editable outside of a
>>>>>> bundle so that a user could make a change to it if necessary.  But let me
>>>>>> rethink that, it might not be necessary for this.
>>>>>>
>>>>>> Thanks again!
>>>>>>
>>>>>> Cheers,
>>>>>> Craig
>>>>>>
>>>>>>
>>>>>> On Mon, May 27, 2013 at 12:16 AM, Jan Bartel <[email protected]>wrote:
>>>>>>
>>>>>>> Craig,
>>>>>>>
>>>>>>> I forgot - there's an even easier way to do this!
>>>>>>>
>>>>>>> Just define inside your bundle manifest the header
>>>>>>> "Jetty-defaultWebXmlFilePath" with either an absolute file location or 
>>>>>>> url,
>>>>>>> or a relative location inside the bundle of a webdefault.xml file. The
>>>>>>> BundleWebAppProvider will see it when it deploys the bundle as a webapp 
>>>>>>> and
>>>>>>> apply it.
>>>>>>>
>>>>>>> Sorry I didn't think of that earlier - I'm going back over the osgi
>>>>>>> documentation even as we speak to ensure its comprehensive!
>>>>>>>
>>>>>>> Jan
>>>>>>>
>>>>>>>
>>>>>>> On 24 May 2013 10:01, Craig Ching <[email protected]> wrote:
>>>>>>>
>>>>>>>> Thanks Jan, I appreciate the response!
>>>>>>>>
>>>>>>>> I did start on trying to configure a DeploymentManager and a
>>>>>>>> BundleWebAppProvider, but without documentation to go with it, I was 
>>>>>>>> afraid
>>>>>>>> I was heading down the wrong path ;-)
>>>>>>>>
>>>>>>>>
>>>>>>>> On Thu, May 23, 2013 at 6:47 PM, Jan Bartel <[email protected]>wrote:
>>>>>>>>
>>>>>>>>> Hi Craig,
>>>>>>>>>
>>>>>>>>> Ooops, looks like I forgot to document a feature of webapp bundles
>>>>>>>>> on the jetty-osgi doco page here:
>>>>>>>>> http://www.eclipse.org/jetty/documentation/current/framework-jetty-osgi.html
>>>>>>>>>
>>>>>>>>> I will update it.
>>>>>>>>>
>>>>>>>>> What you can do is to include a META-INF/jetty-webapp-context.xml
>>>>>>>>> file (name must be exactly as shown)  in your bundle. That is a normal
>>>>>>>>> context xml file that will be applied to the webapp to configure it. 
>>>>>>>>> So you
>>>>>>>>> can set the location of the webdefault.xml file if you like eg:
>>>>>>>>>
>>>>>>>>> <?xml version="1.0"  encoding="ISO-8859-1"?>
>>>>>>>>> <!DOCTYPE Configure PUBLIC "-//Jetty//Configure//EN" "
>>>>>>>>> http://www.eclipse.org/jetty/configure_9_0.dtd";>
>>>>>>>>> <Configure class="org.eclipse.jetty.webapp.WebAppContext">
>>>>>>>>>   <Set name="defaultsDescriptor">file:///tmp/webdefault.xml</Set>
>>>>>>>>> </Configure>
>>>>>>>>>
>>>>>>>>> At the moment, the location of the webdefault.xml has to be
>>>>>>>>> absolute and external to the bundle, but I've opened an issue here:
>>>>>>>>> https://bugs.eclipse.org/bugs/show_bug.cgi?id=408910
>>>>>>>>> to change it so that it can also name a bundle-relative location.
>>>>>>>>> Should get that done before the next jetty-9 release.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> As an alternative, you could also provide your own jetty
>>>>>>>>> configuration files instead of using those in the jettyhome/ dir of 
>>>>>>>>> the
>>>>>>>>> jetty osgi boot core bundle - you would need to define at least a
>>>>>>>>> DeploymentManager and the BundleWebAppProvider, and then tell the
>>>>>>>>> BundleWebAppProvider the location of the webdefault files you want to 
>>>>>>>>> apply
>>>>>>>>> to all webapps that it deploys. However, that is more complicated, and
>>>>>>>>> something I should document rather than trying to explain it in an 
>>>>>>>>> email :)
>>>>>>>>>
>>>>>>>>> Jan
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On 21 May 2013 04:06, Craig Ching <[email protected]> wrote:
>>>>>>>>>
>>>>>>>>>> How do I set the default web descriptor (webdefault.xml) when
>>>>>>>>>> running in OSGi?  Merely putting one in ${jetty.home}/etc/ should 
>>>>>>>>>> have
>>>>>>>>>> worked I would think, but it doesn't appear to have.
>>>>>>>>>>
>>>>>>>>>> Cheers,
>>>>>>>>>> Craig
>>>>>>>>>>
>>>>>>>>>> _______________________________________________
>>>>>>>>>> jetty-users mailing list
>>>>>>>>>> [email protected]
>>>>>>>>>> https://dev.eclipse.org/mailman/listinfo/jetty-users
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Jan Bartel <[email protected]>
>>>>>>>>> www.webtide.com – Developer advice, services and support
>>>>>>>>> from the Jetty & CometD experts.
>>>>>>>>>
>>>>>>>>> _______________________________________________
>>>>>>>>> jetty-users mailing list
>>>>>>>>> [email protected]
>>>>>>>>> https://dev.eclipse.org/mailman/listinfo/jetty-users
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>> _______________________________________________
>>>>>>>> jetty-users mailing list
>>>>>>>> [email protected]
>>>>>>>> https://dev.eclipse.org/mailman/listinfo/jetty-users
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Jan Bartel <[email protected]>
>>>>>>> www.webtide.com – Developer advice, services and support
>>>>>>> from the Jetty & CometD experts.
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> jetty-users mailing list
>>>>>>> [email protected]
>>>>>>> https://dev.eclipse.org/mailman/listinfo/jetty-users
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> jetty-users mailing list
>>>>>> [email protected]
>>>>>> https://dev.eclipse.org/mailman/listinfo/jetty-users
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Jan Bartel <[email protected]>
>>>>> www.webtide.com – Developer advice, services and support
>>>>> from the Jetty & CometD experts.
>>>>>
>>>>> _______________________________________________
>>>>> jetty-users mailing list
>>>>> [email protected]
>>>>> https://dev.eclipse.org/mailman/listinfo/jetty-users
>>>>>
>>>>>
>>>>
>>>> _______________________________________________
>>>> jetty-users mailing list
>>>> [email protected]
>>>> https://dev.eclipse.org/mailman/listinfo/jetty-users
>>>>
>>>>
>>>
>>>
>>> --
>>> Jan Bartel <[email protected]>
>>> www.webtide.com – Developer advice, services and support
>>> from the Jetty & CometD experts.
>>>
>>> _______________________________________________
>>> jetty-users mailing list
>>> [email protected]
>>> https://dev.eclipse.org/mailman/listinfo/jetty-users
>>>
>>>
>>
>> _______________________________________________
>> jetty-users mailing list
>> [email protected]
>> https://dev.eclipse.org/mailman/listinfo/jetty-users
>>
>>
>
>
> --
> Jan Bartel <[email protected]>
> www.webtide.com – Developer advice, services and support
> from the Jetty & CometD experts.
>
> _______________________________________________
> jetty-users mailing list
> [email protected]
> https://dev.eclipse.org/mailman/listinfo/jetty-users
>
>
_______________________________________________
jetty-users mailing list
[email protected]
https://dev.eclipse.org/mailman/listinfo/jetty-users

Reply via email to