We need to update all this documentation still, but fundamentally it is as above in the git formated patch section
git commit -s that adds the required bit Think of it like this, you sign a CLA with eclipse that says you are cleared to contribute to eclipse, but that doesn't mean everything you ever do can be contributed....adding that -s on the commit communicates that you are making that commit under the auspices of your agreement. -- jesse mcconnell [email protected] On Wed, Feb 17, 2016 at 7:12 AM, Marvin Addison <[email protected]> wrote: > On Tue, Feb 16, 2016 at 6:37 PM Jesse McConnell > >> Bright note is that it is much easier for us to accept contributions >> through github, you just need to have a CLA on file and sign the pull >> request appropriately! >> > > Do you have a documentation reference for that process? I see the > following sentence in the contributing docs [1]: > > The commits may need to be signed off so they can be pushed using the git > amend technique above. > > That doesn't sound like the same thing as a signed pull request. > > Thanks, > Marvin > > [1] > http://www.eclipse.org/jetty/documentation/current/contributing-patches.html#d0e24737 > > > _______________________________________________ > jetty-users mailing list > [email protected] > To change your delivery options, retrieve your password, or unsubscribe > from this list, visit > https://dev.eclipse.org/mailman/listinfo/jetty-users >
_______________________________________________ jetty-users mailing list [email protected] To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/jetty-users
