>On Wed, 2006-02-01 at 11:29 +0100, Herbert Poetzl wrote: >> Hi Dave! >> >> sorry for following up on my own email instead >> of your reply, but I'm not subscribed to the >> jfs mailing list, and the archive does not contain >> (or show?) headers so that I could 'fake' a reply >> >> anyway, here are some thoughts about the attributes >> and a patch to look at ...
> It looks good. I only have one question (or two questions that are > basically the same): >> +#define JFS_FL_USER_VISIBLE 0x0FF80000 > why not 0x03f80000? ISYSTEM & IHIDDEN are not mapped to ext2 flags, > so they will get lost by jfs_map() anyway, right? >> +#define JFS_FL_USER_MODIFIABLE 0x03F80000 >> +#define JFS_FL_INHERIT 0x0BC80000 > Any reason that you included ISYSTEM in the JFS_FL_INHERIT flags? ah, you got me there. the original patch I tested is for Linux-VServer and there I have two more flags (see url) but yes, in your version it doesn't make much sense ... so 0x03f80000 and 0x03c80000 should be fine (let me know if you need a new patch) best, Herbert http://vserver.13thfloor.at/Devel/PAT-2.1.1/delta-jfsattr-feat01.diff ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642 _______________________________________________ Jfs-discussion mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/jfs-discussion
