On Mon, 2006-09-11 at 08:33 -0500, Dave Kleikamp wrote:
> On Mon, 2006-09-11 at 14:23 +1000, Tony Breeds wrote:
> > > What is the proper (kernel) way to initialize pxd_t in jfs_txnmgr.c to
> > > silence the warnings?
> >
> > I guess you could do something like:
> >
> > ---
> > if (tlck->type & tlckTRUNCATE) {
> > - pxd_t pxd; /* truncated extent of xad */
> > + /* truncated extent of xad */
> > + pxd_t pxd = {0, 0, 0}; /* FIXME: shutup GCC */
> > int twm;
> > ---
> >
> > But I don't really think that's acceptable.
> >
>
> I'm wondering if the best solution is to just make the assignment
> unconditional. It would probably be more efficient than zeroing it and
> doing the test.
No, there's more going on in the conditional. I'll just fix it as you
suggested. This really isn't a fast path, so the overhead of
initializing on structure is nothing.
Thanks,
Shaggy
--
David Kleikamp
IBM Linux Technology Center
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Jfs-discussion mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jfs-discussion
