On Sun, 2008-05-11 at 22:08 +0200, Marcin Slusarz wrote: > ... so return NULL from jfs_lookup > > Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]>
Signed-off-by: Dave Kleikamp <[EMAIL PROTECTED]> > Cc: [email protected] > Cc: Alexander Viro <[EMAIL PROTECTED]> > --- > is it ok to return NULL from this function? > compile tested only Yeah. I'm not sure how ERR_PTR(0) got in there in the first place. It's been that way for quite a while. I'll add it to the jfs git tree. Thanks, Shaggy > --- > fs/jfs/namei.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/jfs/namei.c b/fs/jfs/namei.c > --- a/fs/jfs/namei.c > +++ b/fs/jfs/namei.c > @@ -1455,7 +1455,7 @@ static struct dentry *jfs_lookup(struct inode *dip, > struct dentry *dentry, struc > free_UCSname(&key); > if (rc == -ENOENT) { > d_add(dentry, NULL); > - return ERR_PTR(0); > + return NULL; > } else if (rc) { > jfs_err("jfs_lookup: dtSearch returned %d", rc); > return ERR_PTR(rc); -- David Kleikamp IBM Linux Technology Center ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Jfs-discussion mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/jfs-discussion
