On 08/01/2012 02:29 PM, Tino Reichardt wrote:
> * Dave Kleikamp <[email protected]> wrote:
>> On 07/28/2012 06:08 AM, Tino Reichardt wrote:
>>> + tt->nblocks = 0; /* mark the current end */
>>> + for (tt = totrim; tt->nblocks != 0; tt++) {
>>> + if (!(JFS_SBI(sb)->flag & JFS_DISCARD)) {
>>> + /* not needed, when online discard is used */
>>
>> Why enter the function at all if JFS_DISCARD is set? But is this really
>> true? Removing files or file fragments that are smaller than
>> minblks_trim will fail to discard them dynamically.
>
> The other FS can also trim via fstrim(8) when mounted with discard
> option :) It is important, that a user can discard all free blocks, even
> when mounting with discard option. The FS could also be mounted several
> times without discard option, and then there are some ranges, where the
> device isn't informed about these ranges. So the batched discard ioctl()
> is then the only way to change that.
>
>
> The comment there was also a bit updated, here is it:
>
> /* when mounted with online discard, dbFree() will
> * call jfs_issue_discard() itself */
Ah. This comments makes it clear. I was forgetting that dbFree will
handle this.
Thanks,
Dave
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Jfs-discussion mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jfs-discussion
