On Fri, Nov 15, 2013 at 12:29:48PM +0800, Jeff Liu wrote: > Hi Folks, > > This patch is trying to introduce a new list helper to retrieve the > last entry or return NULL if the list is empty corresponding to it, > which is inspired by Jiri Pirko's list_first_entry_or_null().
How did we end up with the stupid _or_null prefix there? I think the functionality is useful, but the naming is way to verbose, especially given that a list_first_entry or list_last_entry that optimizes away that one check doesn't seem useful. Instead of encoding detailed semantics in the name a good kerneldoc comment is way better. ------------------------------------------------------------------------------ DreamFactory - Open Source REST & JSON Services for HTML5 & Native Apps OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access Free app hosting. Or install the open source package on any LAMP server. Sign up and see examples for AngularJS, jQuery, Sencha Touch and Native! http://pubads.g.doubleclick.net/gampad/clk?id=63469471&iu=/4140/ostg.clktrk _______________________________________________ Jfs-discussion mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/jfs-discussion
