Christoph,
nice work, and a pretty diffstat.
I see that get_acl and set_acl are being defined in some but not all symlink
inode operations (for example, btrfs them while ext4 does not), and that
posix_acl_xattr_set() doesn't check if set_acl is defined. Symlinks cannot
have ACLs, so set_acl should either never be defined for symlinks (and a NULL
check is then needed in posix_acl_xattr_set()), or it is defined in all inode
operations, and S_ISNLNK() check is needed in posix_acl_xattr_set(). That
latter check should probably be added in any case to be on the safe side.
Test case:
setfattr -h -n system.posix_acl_access \
-v 0sAgAAAAEABgD/////AgAGABMEAAAEAAYA/////xAABgD/////IAAEAP////8= \
symlink
Patch 6 also declares posix_acl_prepare() but this function is never
introduced; this must be a leftover from a previous version.
Thanks,
Andreas
------------------------------------------------------------------------------
Sponsored by Intel(R) XDK
Develop, test and display web and hybrid apps with a single code base.
Download it for free now!
http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk
_______________________________________________
Jfs-discussion mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jfs-discussion
