On Sat, Oct 11, 2014 at 06:34:52AM -0700, Christoph Hellwig wrote: > I still very much disagree with the s_inode_fields indirection. Please > find a patch below to remove it, and use a get_dquots super_block > operation instead. This leads to less and better readable code, > and serves 4 bytes in every inode in the system. Additionally the > indirection could easily be optimized away by directly passing the > dquot array in various functions, but for now I'd like to keep it > simple.
Indeed. This "array of offsets" approach is asking for trouble. Please, don't go there - playing that way with type safety is a bad idea. ------------------------------------------------------------------------------ Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://p.sf.net/sfu/Zoho _______________________________________________ Jfs-discussion mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/jfs-discussion
