On 02/01/2015 10:15 AM, SF Markus Elfring wrote: > From: Markus Elfring <[email protected]> > Date: Sun, 1 Feb 2015 17:00:24 +0100 > > The unload_nls() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <[email protected]>
Thanks! I'll push this upstream. Dave > --- > fs/jfs/super.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/jfs/super.c b/fs/jfs/super.c > index 16c3a95..5d30c56 100644 > --- a/fs/jfs/super.c > +++ b/fs/jfs/super.c > @@ -619,8 +619,7 @@ out_mount_failed: > iput(sbi->direct_inode); > sbi->direct_inode = NULL; > out_unload: > - if (sbi->nls_tab) > - unload_nls(sbi->nls_tab); > + unload_nls(sbi->nls_tab); > out_kfree: > kfree(sbi); > return ret; > ------------------------------------------------------------------------------ Dive into the World of Parallel Programming. The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ Jfs-discussion mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/jfs-discussion
