On Aug 13, 2007, at 10:47 PM, Edward Funnekotter wrote:
Hey Jesse,I made the suggested changes to the patch. Please take a look and let me know if I should commit them.
Commit away! Thanks!
On 8/13/07, Jesse Vincent <[EMAIL PROTECTED]> wrote: Hey Edward, Thanks very much for the patch! I've been talking it through with a couple folks and we have a few style questions/requests. It seems like there's quite a bit of duplicated code in handler_allowed. Is there a base class that stuff could move to? Also, the handler: named block should likely be updated. Named blocks are generally all uppercase in jifty code. Can you send me the output of htpasswd -n under separate cover so I can set you up a commit bit for once the code is cleaned up? Best, Jesse On Aug 11, 2007, at 10:24 PM, Edward Funnekotter wrote: > Hi, > > I noticed that onchange (and other handlers) wasn't implemented, so > I decided to try to add support for it. Here is a patch that adds > that support for most of the missing handlers. > > Since I am fairly new at Jifty internals, I suspect that the style > may not be completely inline with what you guys like. Please > either change what I have or suggest changes and I will make them. > > If you prefer me to commit this stuff, lob me a commit bit and I > will do it. > > Thanks, > Edward > > > <handlers_patch.gz> > _______________________________________________ > jifty-devel mailing list > [email protected] > http://lists.jifty.org/cgi-bin/mailman/listinfo/jifty-devel _______________________________________________ jifty-devel mailing list [email protected] http://lists.jifty.org/cgi-bin/mailman/listinfo/jifty-devel <handlers_patch.gz> _______________________________________________ jifty-devel mailing list [email protected] http://lists.jifty.org/cgi-bin/mailman/listinfo/jifty-devel
PGP.sig
Description: This is a digitally signed message part
_______________________________________________ jifty-devel mailing list [email protected] http://lists.jifty.org/cgi-bin/mailman/listinfo/jifty-devel
