On 17/02/2015 20:59, Jason Uh wrote:
Please review this fix, which removes the sun.security.acl package.

webrev: http://cr.openjdk.java.net/~juh/8072663/00/
jbs: http://bugs.openjdk.java.net/browse/JDK-8072663

The sun.security.acl package is the default implementation of java.security.acl but it's not used in JDK. The JCK tests for java.security.acl only covers the three exception classes and there are no JDK tests for the interfaces, implying that the spec does not require the implementation of java.security.acl interfaces. This is likely because java.security.acl package have been superseded by classes in the java.security package since 1.2.

Removing the sun.security.acl implementation will help offset the increase in size to the base module that was caused by moving java.security.acl from a separate dedicated module to java.base (see http://bugs.openjdk.java.net/browse/JDK-8069551).
The changes looks good, assuming there is no way that the sun.security.acl classes will be used by anything else in the standard APi. I didn't realize there was a reference to the implementation classes in the java.security.acl javadoc.

-Alan

Reply via email to