On 18 Jun 2015, at 20:48, Mandy Chung <mandy.ch...@oracle.com> wrote:
> http://cr.openjdk.java.net/~jlaskey/hs-rt-jimage/webrev-top > modules.xml looks fine. > > test/lib/sun/hotspot/WhiteBox.java > This adds the native entry points. Where are they implemented? It’s > not obvious to me. The native is in hotspot repo vm/prims > > http://cr.openjdk.java.net/~jlaskey/hs-rt-jimage/webrev-langtools > the jdeps change looks fine. > > http://cr.openjdk.java.net/~jlaskey/hs-rt-jimage/webrev-jdk/ > This is a huge patch that I have to rely on the extensive testing to catch > potential issues. I tried running the jrt-fs tests using JDK 8 with > jrt-fs.jar that work well. Some comments and mostly minor. > > make/gensrc/Gensrc-jdk.dev.gmk > - you could revert this one Done > > make/src/classes/build/tools/module/ImageBuilder.java > Nit: line 366, 382 - left over commented lines > some indentation/formatting nits line 386-397 Done > > jdk/tools/jimage/TaskHelper.java > 43 static final long serialVersionUID = 8765093759964640721L; // ## > re-generate Removed the comment > > jdk/tools/jimage/JImageTask.java > The start year is replaced in the copyright header. You should add the end > year instead. Done > > test/java/nio/Buffer/LimitDirectMemory.sh > test/java/nio/file/spi/SetDefaultProvider.java > Why this test is ignored? Done, JDK bug logged. > > Mandy Thanks. JF > >> On Jun 17, 2015, at 5:08 PM, Jim Laskey (Oracle) <james.las...@oracle.com> >> wrote: >> >> https://bugs.openjdk.java.net/browse/JDK-8080511 >> >> This is an long overdue refresh of the jimage support in the JDK9-dev repo. >> This includes native support for reading jimage files, improved jrt-fs (java >> runtime file system) support for retrieving modules and packages from the >> runtime, and improved performance for langtools in the presence of jrt-fs. >> >> http://cr.openjdk.java.net/~jlaskey/hs-rt-jimage/webrev-top >> <http://cr.openjdk.java.net/~jlaskey/hs-rt-jimage/webrev-top> >> http://cr.openjdk.java.net/~jlaskey/hs-rt-jimage/webrev-jdk >> <http://cr.openjdk.java.net/~jlaskey/hs-rt-jimage/webrev-jdk> >> http://cr.openjdk.java.net/~jlaskey/hs-rt-jimage/webrev-hotspot >> <http://cr.openjdk.java.net/~jlaskey/hs-rt-jimage/webrev-hotspot> >> http://cr.openjdk.java.net/~jlaskey/hs-rt-jimage/webrev-langtools >> <http://cr.openjdk.java.net/~jlaskey/hs-rt-jimage/webrev-langtools> >> >> >> Details: >> >> - jrt-fs provides access, via the nio FileSystem API, to the classes in a >> .jimage file, organized by module or by package. >> - Shared code for jimage support converted to native. Currently residing in >> hotspot, but will migrate to it’s own jdk library >> https://bugs.openjdk.java.net/browse/JDK-8087181 >> <https://bugs.openjdk.java.net/browse/JDK-8087181> >> - A new archive abstraction for class/resource sources. >> - java based implementation layer for jimage reading to allow backport to >> JDK8 (jrt-fs.jar - IDE support.) >> - JNI support for jimage into hotspot. >> - White box tests written to exercise native jimage support. >> >
