Thanks Alan, I had read the spec from https://docs.oracle.com/javase/8/docs/technotes/guides/jni/spec/functions.html#array_operations And it was not clear.
On 10 Jul 2015, at 18:34, Alan Bateman <alan.bate...@oracle.com> wrote: > > > On 10/07/2015 16:46, Jean-Francois Denise wrote: >> Hi, >> asking review for this bug fix. >> http://cr.openjdk.java.net/~jfdenise/JDK-8130344/ >> > I assume if JNI's NewByteArray returns NULL then it does so with a pending > OOME. You might want to double check the JNI spec on this. If it guarantee it > then you might need not need the null check in getStringBytes. > > The change to Image.c looks okay. In other areas of the libraries we have > macros to do this. > > -Alan.
