> On Nov 10, 2015, at 10:11 AM, Alexandre (Shura) Iline > <alexandre.il...@oracle.com> wrote: > >> >> On Nov 10, 2015, at 9:04 PM, Mandy Chung <mandy.ch...@oracle.com> wrote: >> >> Hi Shura, >> >> Thanks for doing it and it’s good to see the unnecessary dependency to >> java.management eliminated. >> >> The new jdk.testlibrary.management package name is fine. It’s okay to keep >> the class name InputArguments as Jaroslav suggests and it’s easier to tell >> what this class is about. >> >> There is a copy of ProcessTools and InputArguments in the hotspot repository >> under >> hotspot/test/testlibrary/jdk/test/lib/ >> >> Are we planning to remove this duplicated copy? If not, same patch should >> be applied to those copy. It’s fine to separate this and push the hotspot >> test library change via hotspot-rt repo. Christian can probably sponsor the >> patch for you. > > This is the bug to track the library merge: > https://bugs.openjdk.java.net/browse/JDK-8075327 > > It is there for a long time for discussion, so I would not suggest to wait > for it. If a parallel fix is needed, I would rather just do it. >
I agree. I suggest to file a bug and apply this fix in the hotspot test library as a separate patch. Mandy
