On 15/12/2015 15:41, Lois Foltan wrote:
:
This is definitely a good start for updating JDK and JDWP for
modules. I did have a chance to look over the hotspot changes. I
would really prefer not to introduce a new ModulesTable data structure
(modules.c/hpp). The goal of the JVM support for jigsaw was to have
one stop shopping with ModuleEntryTable and PackageEntryTable. Those
data structures keep track and record the module definitions. As a
matter of fact, last week Harold completely removed JDK 9's current
PackageInfo Hashtable in the jake repo in favor of using the new
PackageEntryTable. I can help by enhancing ModuleEntryTable to
provide methods that Modules::get_all_modules() could call. Would you
be okay with that?
That would be good and should make it easy to use from
JvmtiEnv::GetAllModules.
-Alan.
