Re: hg: jigsaw/jake/langtools: support module files directly on file manager module paths

[Jonathan Gibbons]

Robert,

Noted.  Thanks for the report.   That should be easy enough to fix.

-- Jon

On 02/03/2016 09:38 AM, Robert Scholte wrote:

Hi Jonathan,

it seems like this change is not enough, see: Locations.ModulePathLocationHandler::setPaths

910
        @Override
911
        void setPaths(Iterable<? extends Path> paths) {
912
            if (paths != null) {
913
                for (Path p: paths) {
914
                    if (!Files.isDirectory(p))
915
                        throw new IllegalArgumentException(p.toString());
916
                }
917
            }
918
            super.setPaths(paths);
919
        }

I still got the IAE.

thanks,
Robert


Op Thu, 21 Jan 2016 02:59:30 +0100 schreef <jonathan.gibb...@oracle.com>:

Changeset: 546b5fa35f9a
Author:    jjg
Date:      2016-01-20 17:58 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/546b5fa35f9a

support module files directly on file manager module paths

! src/jdk.compiler/share/classes/com/sun/tools/javac/file/Locations.java