+1 -Sundar
On 3/30/2016 7:09 PM, Felix Yang wrote: > Hi all, > renamed the test to distinguish with other jrt fs tests and also > fixed some misc issues. > New webrev: http://cr.openjdk.java.net/~xiaofeya/8141609/webrev.03/ > > Thanks, > Felix > On 2016/3/3 15:48, Felix Yang wrote: >> Hi Alan and Sundar, >> please review the new webrev. Simplified the test app as discussed. >> http://cr.openjdk.java.net/~xiaofeya/8141609/webrev.02/ >> >> Thanks, >> Felix >> On 2016/3/1 16:07, Alan Bateman wrote: >>> >>> >>> On 01/03/2016 05:47, Felix Yang wrote: >>>> Hi Alan, >>>> please review the new webrev: >>>> http://cr.openjdk.java.net/~xiaofeya/8141609/webrev.02/ >>>> >>>> Major changes: >>>> 1. remove checking for 'java.version' in JrtfsTestMain and add new >>>> check for 'release' file >>>> 2. In order to avoid dup tests with Basic.java, add new >>>> BaseTest.java, which is a plain java app rather than testng tests. >>>> As stated before, only moved those tests more related with >>>> 'functionality', not contents. >>>> >>> This refactors the main unit test for jrtfs and means it can't use >>> newer APIs or language features. I'm interested in Sundar's view on >>> this but I think I would prefer to need to keep the test separate so >>> that it can compile to -target 8. Also I assume it just needs to do >>> a few sanity checks, like walk the file system. Once we have >>> something simple in place then we can add tests to it if needed. >>> >>> -Alan >> >
