Hi Alan,
I also have a little optimization for Module.extraPackages:
http://cr.openjdk.java.net/~plevart/jdk9-dev/Module.extraPackages/webrev.01/
This is only used from java.lang.reflect.Proxy presently, so what is
currently there is not performance critical, but if it gets used more,
then the provided patch gives smaller footprint and O(n) instead of
O(n^2) time to add n packages to a module + doesn't produce so much garbage.
What do you think?
On 04/27/2016 06:05 PM, alan.bate...@oracle.com wrote:
Changeset: 8816a52d31dd
Author: plevart
Date: 2016-04-27 10:49 +0100
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/8816a52d31dd
java.lang.reflect.Module.WeakSet is not thread-safe
! src/java.base/share/classes/java/lang/reflect/Module.java
+ src/java.base/share/classes/java/lang/reflect/WeakPairMap.java
+ test/java/lang/reflect/WeakPairMap/Driver.java
+
test/java/lang/reflect/WeakPairMap/java.base/java/lang/reflect/WeakPairMapTest.java
Changeset: 243ea7e92d19
Author: alanb
Date: 2016-04-27 11:10 +0100
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/243ea7e92d19
Merge
! src/java.base/share/classes/java/lang/reflect/Module.java
Changeset: ba169b23b4c7
Author: alanb
Date: 2016-04-27 15:31 +0100
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/ba169b23b4c7
Add support for -addmods ALL-DEFAULT
! make/launcher/Launcher-java.desktop.gmk
! make/launcher/Launcher-java.scripting.gmk
! make/launcher/Launcher-jdk.compiler.gmk
! make/launcher/Launcher-jdk.javadoc.gmk
! make/launcher/Launcher-jdk.jlink.gmk
! make/launcher/Launcher-jdk.scripting.nashorn.shell.gmk
! src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java
! test/tools/launcher/modules/addmods/AddModsTest.java
- test/tools/launcher/modules/addmods/src/app/Main.java
- test/tools/launcher/modules/addmods/src/lib/jdk/lib/Util.java
- test/tools/launcher/modules/addmods/src/lib/module-info.java
+ test/tools/launcher/modules/addmods/src/logger/logger/Logger.java
+ test/tools/launcher/modules/addmods/src/logger/module-info.java
+ test/tools/launcher/modules/addmods/src/test/module-info.java
+ test/tools/launcher/modules/addmods/src/test/test/Main.java
