On 30/04/2016 05:48, Mandy Chung wrote:
:
I reviewed all repos except hotspot. Looks good in general. Minor comments:
Configuration.java
Nit: line 361-364 there is an extra space
Will fix.
sun/tools/jar/Main.java
In the printModuleDescriptor method, creating a List from a stream is not
necessary.
1668 md.requires().stream().sorted().collect(toList()).forEach(
sortExports can be replaced as well.
I have a patch to clean this up that I can push to jake:
http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/jar-jmod-cleanup/
Go ahead, I have another small batch of clean-ups to get in too so I'll
refresh the webrev on Monday.
-Alan
