Hi Alan,

On 2016/5/24 14:59, Alan Bateman wrote:
On 24/05/2016 07:35, John Jiang wrote:
Hi,
Please review this patch on fixing module dependencies for /sun/* tests.

Issue: https://bugs.openjdk.java.net/browse/JDK-8157635
Webrev: http://cr.openjdk.java.net/~jjiang/8157635/webrev.00/

Is dns/cname.sh really using module java.naming now? Just asking because I thought the name service provider mechanism has been removed so InetAddress can no longer be configured to use the JNDI DNS provider.
CanonicalName.java, which is a part of the test, is using java.naming APIs.

In sun/security/provider/PolicyFile/Modules.java then it would be good to sort the module names as it will be others hard to maintain this list.
Please review the updated webrev [1].

[1] http://cr.openjdk.java.net/~jjiang/8157635/webrev.01

Best regards,
John Jiang

Reply via email to