> On Jun 1, 2016, at 12:33 PM, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 01/06/2016 15:47, Jim Laskey (Oracle) wrote: > >> http://cr.openjdk.java.net/~jlaskey/8156994/webrev/index.html >> https://bugs.openjdk.java.net/browse/JDK-8156994 > Good to see this fixed. I wonder about the usage message for -verify : > "Reports on any .class entries that don't verify as classes" > > "verify" isn't clear here, one might thing it runs the verifier when all it > does is check that each class resource has the 0xCAFEBABE magic number. > Instead of changing the usage message then what would you think about > changing the implementation to work like the VerifyJImage test? Separate > issue of course but I suspect it might be more useful. We could even think > about having it be run in the build.
I have looked at the VerifyJImage test and wonder how it works if jimage being used is not the boot jimage. Would creating a loader and using defineClass be reasonable? > > -Alan
