> On 25 Aug 2016, at 09:33, Mandy Chung <mandy.ch...@oracle.com> wrote: > > >> On Aug 25, 2016, at 7:18 AM, Sundararajan Athijegannathan >> <sundararajan.athijegannat...@oracle.com> wrote: >> >> Please review http://cr.openjdk.java.net/~sundar/8147491/webrev.01/ for >> https://bugs.openjdk.java.net/browse/JDK-8147491 > > > I think ResourcePoolConfiguration::validate should simply use all modules in > the resource pool as the roots. ImagePluginStack constructors don’t need to > know anything about the input root modules. >
I am under of the mechanics of this aspect. It would nice to avoid the propagation of the Set but presumably the validation should not be using the roots after all plugins have been run, since a plugin could add a new module? > Other than that, it looks fine. > +1 Paul.
