> On Sep 15, 2016, at 7:31 AM, Sundararajan Athijegannathan > <sundararajan.athijegannat...@oracle.com> wrote: > > Please review http://cr.openjdk.java.net/~sundar/8160063/webrev.01/ for > https://bugs.openjdk.java.net/browse/JDK-8160063 > > * Adding --disable-<plugin_name> option for any plugin that is auto-enabled.
A consistent mechanism to disable a plugin is good. The Section class is not used anywhere. Should the entire class be removed? Or move it to JmodArchive to replace the final String constants. Can you include "--disable-<plugin_name>” and its help message in jlink —-list-plugins help output? It can be placed toward the bottom before: For options requiring a <pattern-list>, the value will be a comma separated list of elements each using one the following forms: <glob-pattern> glob:<glob-pattern> regex:<regex-pattern> @<filename> where filename is the name of a file containing patterns to be used, one pattern per line Can you also fix the two long lines above as missing \n in main.extended.help.footer Otherwise, looks fine. Mandy
