Looks good to me, +1.
It seems correct that it’s the responsibility of the users of Dynalink to add
the read edges from their own modules.
> On 12 Oct 2016, at 18:31, Sundararajan Athijegannathan
> <sundararajan.athijegannat...@oracle.com> wrote:
> Updated nashorn webrev:
> Changed to use Layer.boot().findModule.
> On 10/12/2016 9:42 PM, Alan Bateman wrote:
>> On 12/10/2016 16:33, Sundararajan Athijegannathan wrote:
>>> Dynalink used to automatically add those necessary add edges. With the
>>> current change, nashorn adds necessary read edges. CallerSensitive
>>> methods are found only in java.base, java.logging, java.sql and
>>> java.sql.rowset modules - the first two are always present [in nashorn's
>>> compact1 dependency world]. The later two are checked for presence and
>>> read-edges are added conditionally (see ScriptLoader.java changes).
>> JDK-8154346 tracks fixing java.sql.DriverManager, there are
>> compatibility concerns to changing it but it is being looked at.
>> I'm not familiar with the issue in the java.sql.rowset module but it
>> may be that the security checks in SerialJavaObject::getFields can be
>> re-visited (I don't know all the history on that).
>>> Yes, I need boot layer modules only and I'll change that.