> On Oct 22, 2016, at 3:06 AM, Alan Bateman <alan.bate...@oracle.com> wrote:
> 
> On 21/10/2016 22:07, Alexandre (Shura) Iline wrote:
> 
>> Alan,
>> 
>> This is a newer version:
>> http://cr.openjdk.java.net/~shurailine/8159523/webrev.03/
>> 
> The usages looks good in this version, would be interesting to get other 
> opinions (although this isn't specifically module options, this is really 
> more about replacing usages of ProcessTools).
> 
> One small comment is that I'm not sure about Task defining ALL-UNNAMED. It 
> might be simpler to leave addExports taking two options so that the LHS is 
> more obvious in the tests that use.

Like this:
http://cr.openjdk.java.net/~shurailine/8159523/webrev.04/

Shura

> 
> -Alan
> 

Reply via email to