Hi Chris,

Changes looks good. I think tests should be added for case when there are 
extracted files in directory.


—Andrey
> On 6 Dec 2016, at 14:44, Chris Hegarty <chris.hega...@oracle.com> wrote:
> 
> [ forwarding to a more appropriate list to review this change ]
> 
>> Begin forwarded message:
>> 
>> From: Chris Hegarty <chris.hega...@oracle.com>
>> Subject: RFR [9] 8166568 & 8169492 jmod extract and bug fix
>> Date: 6 December 2016 at 10:46:08 GMT
>> To: core-libs-dev <core-libs-...@openjdk.java.net>
>> 
>> This change adds a basic option to the jmod tool to extract all its contents 
>> to
>> the current working directory, 8166568 [1]. Additionally, there is a bug fix 
>> for
>> a public mutable static, 8169492 [2].
>> 
>> http://cr.openjdk.java.net/~chegar/8166568_8169492.00/
>> 
>> -Chris.
>> 
>> [1] https://bugs.openjdk.java.net/browse/JDK-8166568
>> [2] https://bugs.openjdk.java.net/browse/JDK-8169492
> 

Reply via email to