Hello,

I don't quite understand this. In the proposition below it says osx, and x64, but in platform.m4 you generate macos and amd64. Does this then get translated again and why are we introducing yet another name for the operating system on Apple computers?

/Erik


On 2017-04-03 20:41, Mandy Chung wrote:
Webrev:
   http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8175819/webrev.00/

This revisits the OS name and arch in packaging JDK modules
to extend the module descriptor with ModuleTarget class file
attribute.  We considered matching with the system properties.
Linux x64 JDK can run on a system whose `os.arch` system
property value can be `amd64` or `i586` or `x86_x64`.
Similiarly, windows x86/x64 JDK can run on a system whose
`os.name` system property starts with “Windows” as the
os.name property is set to "Windows XXX" for example
"Windows Server 2012 R2”.  It might be worth considering
multiple OS arch values in ModuleTarget in the future.

JDK bundle names are revised in JDK 9.  This is a good
alternative to be consistent with $OS-$ARCH value in
the bundle names.  This patch proposes to package JDK modules
with OS name and arch to match the values as in JDK bundle names.
jlink will generate the `release` file and set OS_NAME and
OS_ARCH to those values.  This also proposes to drop
OS_VERSION to align with the ModuleTarget class file attribute.

This shows the old and new value of OS_NAME/OS_ARCH properties
in the `release` file:

             JDK 8               JDK 9
             -----               -----
OS_NAME     Linux               linux
             SunOS               solaris
             Darwin              osx
             Windows             windows
OS_ARCH i386,x86 x86
             i586,amd64,x86_64   x64
             sparcv9             sparcv9
             arm                 arm32
             aarch64             arm64

Mandy

Reply via email to