Hi Alan,
In the Launcher-Agent-Class, would it make sense to use 'premain'
instead of 'agentmain'
to align it with Premain-Class rather than with Agent-Class?
(maybe even rename Launcher-Agent-Class to Launcher-Premain-Class?)
AFAIU Launcher-Agent-Class is meant to replace a particular use case of
self-attach in applications - hence the 'agentmain'.
But on the other hand, it is essentially a "shortcut" for '-jar app.jar
-javaagent:app.jar', so 'premain' might as well be expected to be used
(especially by a new user).
Also Launcher-Agent-Class is invoked before the application, like
Premain-Class and unlike Agent-Class,
and some agents out there might use the entry method (premain or
agentmain declared by the same class) to determine how they were invoked.
It will not be possible if 'agentmain' can be invoked both before and
after 'main'
(using different classes for Premain-Class, Agent-Class and
Launcher-Agent-Class will still work though).
Thanks,
Stas
On 01.05.2017 23:28, Alan Bateman wrote:
As I mentioned in another thread, we need to get the changes
accumulated in jake to jdk9/dev.
JDK-8178380 [1] has the summary of the changes that have accumulated
since the last refresh.
One note on the hotspot repo is that the changes to dynamically
augment the platform modules run into JDK-8178604 when testing with an
exploded build. So there is a partial fix for this in jake. Harold has
the more complete fix in review on hotspot-runtime-dev for JDK 10.
The webrevs with the changes is here:
http://cr.openjdk.java.net/~alanb/8178380/1/
-Alan
[1] https://bugs.openjdk.java.net/browse/JDK-8178380
