Hi Mandy, No problem. Wasn't sure where the limit was on line lengths, so I will watch and learn :)
Thanks Michael On 9 November 2017 at 13:22, mandy chung <mandy.ch...@oracle.com> wrote: > Hi Michael, > > It is indeed a bug and I file: > https://bugs.openjdk.java.net/browse/JDK-8190987 > > The patch looks good and I will sponsor this patch for you. > > Thanks for the regression test. It'd be good to wrap the long lines and I > will clean that up before I push. > > thanks > Mandy > > On 11/8/17 5:07 PM, Michael D wrote: >> >> Hi All, >> >> Hope I'm in the right place. >> The implementation of Jigsaw caused a regression in that >> Package.getImplementationVersion is unusable if no other version >> things are defined in the manifest. >> This appears to be an unintentional regression caused by a missing null >> check. >> I have prepared a patch and unit test for review here: >> https://patch-diff.githubusercontent.com/raw/md-5/OpenJDK/pull/3.patch >> Note that only testImplVersion fails, but I have included tests for >> all the version elements for completeness. >> >> NB: Not an OpenJDK dev so can't create webrev or bug report. >> >> Thanks >> Michael > >
