On 02/16/2018 02:45 PM, Alan Bateman wrote:
On 16/02/2018 13:35, Michal Vala wrote:
:
Sure I can do that. However, all output messages are defined at
jimage.properties (jdk.jlink module) file and this won't be possible for this
case. I can't tell whether IOExcaption is caused by wrong jimage file or
something else so all I can do is really just print an exception message.
The jimage tool is for troubleshooting purposes, it's not a tool that we expect
many developers to every use directly. It should be okay if the resource is
something like "Unable to open {0}: {1}" where {0} is the file path specified to
the tool, and {1} is the exception message.
That sounds reasonable. Here's the webrev:
http://cr.openjdk.java.net/~shade/8170120/webrev.01/
It fixes JImageVerifyTest so I've removed it from ProblemList.
note: JImageExtractTest still failing on not-empty-dir(JDK-8170114) and
JImageListTest fails on simplest list test. I'll take a look at it later.
--
Michal Vala
OpenJDK QE
Red Hat Czech
