On 28/11/2018 13:49, Claes Redestad wrote:
Hi Erik,

looks good to me!

(Nit) You could consider the old TreeMap trick to ensure key-sorted map iteration order:

// convert to a TreeMap to ensure sorted iteration order for (var e : new TreeMap<>(map).entrySet()) { Thanks!

I agree TreeMap would be simpler in generate method where we should just need to change "locals" to be a TreeMap rather than a HashMap. The rest looks okay to me.

-Alan

Reply via email to