On 15/02/2019 21:24, Mikael Vidstedt wrote:
Please review this change which addresses some warnings generated by GCC 8.2
related to the uses of strncpy in libjimage/imageFile.cpp.
Bug: https://bugs.openjdk.java.net/browse/JDK-8219142
Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8219142/webrev.00/open/webrev/
<http://cr.openjdk.java.net/~mikael/webrevs/8219142/webrev.00/open/webrev/>
In addition to feedback on the change itself, I’m taking suggestions on what
tests to run. An earlier version of the change passed the typical tier1
testing. I’m going to run tier1 on this version as well, but let me know if
there are additional tests I should run.
The jrtfs tests cover this area, the path to specify to jtreg is
jdk/jdk/internal/jrtfs.
I skimmed through the changes and all red looks good :-) I assume the
bug description can be changed as it's now about removing unused jimage
functions rather than changes to works with a newer version of gcc.
-Alan
