> On 18 Nov 2019, at 12:34, Alan Bateman <alan.bate...@oracle.com> wrote:
> 
> ...
>   http://cr.openjdk.java.net/~alanb/8233922/webrev/

I think this looks ok.

The original patch that added incubator module support had similar changes ( to 
exclude incubator modules from service binding ), but it impacted on the public 
Configuration::resolveAndBind ( so backed away from doing this ). Your changes 
to limit this to the boot layer are good ( since it is unlikely to be a more 
general issue ).

I’m surprise to see the resolver use `mres.hasIncubatingWarning() == false`, 
rather than ModuleResolution.doNotResolveByDefault(mres).

-Chris.




Reply via email to