[ 
https://issues.apache.org/jira/browse/ARROW-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17153566#comment-17153566
 ] 

Joris Van den Bossche commented on ARROW-9347:
----------------------------------------------

> Shall we have an integration test for it similarly like we have for turbodbc 
> and dask?


I am not sure it is worth an extra build. it's also not like dask, where we run 
dask's tests to ensure _we_ don't break dask. Here it would be more like 
pandas, where we run our tests against multiple versions of fsspec. Installing 
fsspec master in one of the existing builds might be fine though (but not sure 
if that's easy to do in the way the builds are set up?)

> [Python] Tests fail with latest fsspec
> --------------------------------------
>
>                 Key: ARROW-9347
>                 URL: https://issues.apache.org/jira/browse/ARROW-9347
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Python
>            Reporter: Antoine Pitrou
>            Assignee: Joris Van den Bossche
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.0.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Using the latest fsspec from upstream git repo (changeset 
> 656be423ef36ac533fd3319850e107c2669cce3d), I get this error when running the 
> tests:
> {code}
> Traceback (most recent call last):
>   File "/home/antoine/arrow/dev/python/pyarrow/tests/test_fs.py", line 778, 
> in test_move_directory
>     fs.move(s, t)
>   File "pyarrow/_fs.pyx", line 519, in pyarrow._fs.FileSystem.move
>     check_status(self.fs.Move(source, destination))
>   File "pyarrow/_fs.pyx", line 1024, in pyarrow._fs._cb_move
>     handler.move(frombytes(src), frombytes(dest))
>   File "/home/antoine/arrow/dev/python/pyarrow/fs.py", line 173, in move
>     self.fs.mv(src, dest)
>   File 
> "/home/antoine/miniconda3/envs/pyarrow/lib/python3.7/site-packages/fsspec/spec.py",
>  line 743, in mv
>     self.rm(path1, recursive=recursive)
>   File 
> "/home/antoine/miniconda3/envs/pyarrow/lib/python3.7/site-packages/fsspec/implementations/local.py",
>  line 108, in rm
>     os.remove(path)
> IsADirectoryError: [Errno 21] Is a directory: 
> '/tmp/pytest-of-antoine/pytest-0/test_move_directory_PyFileSyst1/source-dir'
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to