[
https://issues.apache.org/jira/browse/ARROW-9550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy Grove closed ARROW-9550.
-----------------------------
Resolution: Invalid
The use of Rc<RefCell<_>> is actually an optimization. Removing this makes
performance worse.
> [Rust] [DataFusion] Remove Rc<RefCell<_>> from hash aggregate operator
> ----------------------------------------------------------------------
>
> Key: ARROW-9550
> URL: https://issues.apache.org/jira/browse/ARROW-9550
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Rust, Rust - DataFusion
> Reporter: Andy Grove
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.0.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The hasg aggregate operator runs on a thread and therefore does not require
> Rc<RefCell<_>> usage and could just use mutable references instead.
> This does require some refactoring of the logic so that the code simply
> iterates over the rows, calling get_mut on the hashmap per row.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
