Krisztian Szucs created ARROW-10064:
---------------------------------------

             Summary: [C++] Resolve compile warnings on Apple Clang 12
                 Key: ARROW-10064
                 URL: https://issues.apache.org/jira/browse/ARROW-10064
             Project: Apache Arrow
          Issue Type: Improvement
          Components: C++
            Reporter: Krisztian Szucs
            Assignee: Krisztian Szucs
             Fix For: 2.0.0


{code}
../src/arrow/util/uri.cc:172:19: error: loop variable 'seg' of type 'const 
nonstd::sv_lite::basic_string_view<char, std::__1::char_traits<char> >' creates 
a copy from type 'const nonstd::sv_lite::basic_string_view<char, 
std::__1::char_traits<char> >' [-Werror,-Wrange-loop-analysis]
  for (const auto seg : segments) {
                  ^
../src/arrow/util/uri.cc:172:8: note: use reference type 'const 
nonstd::sv_lite::basic_string_view<char, std::__1::char_traits<char> > &' to 
prevent copying
  for (const auto seg : segments) {
       ^~~~~~~~~~~~~~~~
                  & {code}

{code}
../src/arrow/ipc/metadata_internal.cc:1157:20: error: loop variable 'pair' is 
always a copy because the range of type 'const arrow::ipc::internal::KVVector' 
(aka 'const Vector<Offset<flatbuf::KeyValue> >') does not return a reference 
[-Werror,-Wrange-loo
p-analysis]
  for (const auto& pair : *fb_metadata) {
                   ^
../src/arrow/ipc/metadata_internal.cc:1157:8: note: use non-reference type 
'const org::apache::arrow::flatbuf::KeyValue *'
  for (const auto& pair : *fb_metadata) {
       ^~~~~~~~~~~~~~~~~~
{code}





--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to