[ 
https://issues.apache.org/jira/browse/ARROW-10139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17205155#comment-17205155
 ] 

Kouhei Sutou commented on ARROW-10139:
--------------------------------------

OK.

How about adding new {{ARROW_TESTING}} option like existing 
{{ARROW_${COMPONENT}}} options and changing {{ARROW_BUILD_TESTS}} to enable 
{{ARROW_TESTING}} implicitly?
If {{ARROW_TESTING}} is enabled, {{libarrow_testing.so}} is built and installed.
If {{ARROW_BUILD_TESTS}} is enabled, {{ARROW_TESTING}} is enabled implicitly. 
So {{libarrow_testing.so}} is installed by {{ARROW_BUILD_TESTS}}.

> [C++] Tests should not install extra files
> ------------------------------------------
>
>                 Key: ARROW-10139
>                 URL: https://issues.apache.org/jira/browse/ARROW-10139
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>            Reporter: Yuri
>            Priority: Major
>             Fix For: 2.0.0
>
>
> It installs:
> {noformat}
> lib/cmake/arrow/ArrowTestingConfig.cmake
> lib/cmake/arrow/ArrowTestingConfigVersion.cmake
> lib/cmake/arrow/ArrowTestingTargets-%%CMAKE_BUILD_TYPE%%.cmake
> lib/cmake/arrow/ArrowTestingTargets.cmake
> lib/cmake/arrow/FindArrowTesting.cmake
> lib/libarrow_testing.so
> lib/libarrow_testing.so.100
> lib/libarrow_testing.so.100.1.0
> libdata/pkgconfig/arrow-testing.pc
> {noformat}
> The original GitHub bug report: [https://github.com/apache/arrow/issues/8306]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to