[ 
https://issues.apache.org/jira/browse/ARROW-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212827#comment-17212827
 ] 

Kouhei Sutou commented on ARROW-9572:
-------------------------------------

Unfortunately, no.
ARROW-10273 just fixes the way how to run self test described in 
https://docs.brew.sh/How-To-Open-a-Homebrew-Pull-Request#create-your-pull-request-from-a-new-branch
 . (It also backports the change in 
https://github.com/Homebrew/homebrew-core/pull/60189 .)
But it doesn't check build dependency that is done by Homebrew's CI: 
https://github.com/Homebrew/homebrew-core/blob/master/.github/workflows/tests.yml#L64-L72
We can't detect a bug that LLVM is needed at run-time yet.

> [CI][Homebrew] Properly enable Gandiva and improve testing
> ----------------------------------------------------------
>
>                 Key: ARROW-9572
>                 URL: https://issues.apache.org/jira/browse/ARROW-9572
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++ - Gandiva, Packaging
>            Reporter: Neal Richardson
>            Assignee: Neal Richardson
>            Priority: Major
>             Fix For: 3.0.0
>
>
> ARROW-9086 enabled Gandiva in our Homebrew formula, but when I tried to add 
> that to the official Homebrew formula at release time, it failed. See some 
> discussion at https://github.com/Homebrew/homebrew-core/pull/58581, though 
> unfortunately the build logs are gone. 
> It turns out that the testing that Homebrew does is more thorough than the 
> install/audit we do in CI. See 
> https://github.com/Homebrew/homebrew-core/pull/58581/checks?check_run_id=915732878
>  for example. They install, build the bottle, then remove all dependencies 
> and reinstall the bottle. Since this failed, what I think it means is that 
> `llvm` is not a build-only dependency for Gandiva--it built but couldn't run 
> successfully because `llvm` had been removed.
> cc [~kou]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to