[
https://issues.apache.org/jira/browse/ARROW-11248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Qingyou Meng updated ARROW-11248:
---------------------------------
Description:
According to the comments from function `set_bits`:
{code:java}
/// sets all bits on `write_data` on the range
`[offset_write..offset_write+len]` to be equal to the
/// bits on `data` on the range `[offset_read..offset_read+len]`{code}
The function has a defect if `write_data` contains non-null bits: it does not
unset bits and update the `diff count`. Perhaps should add comment to state
that `write_data` in range `[offset_write..offset_write+len]` *has been zeroed
out.*
was:
According to the comments from function `set_bits`:
{code:java}
/// sets all bits on `write_data` on the range
`[offset_write..offset_write+len]` to be equal to the
/// bits on `data` on the range `[offset_read..offset_read+len]`{code}
The function has a defect if `write_data` contains non-null bits: it does not
unset bits and update the `diff count`.
> [Rust] [Arrow] defects in array::transform::utils::set_bits()
> -------------------------------------------------------------
>
> Key: ARROW-11248
> URL: https://issues.apache.org/jira/browse/ARROW-11248
> Project: Apache Arrow
> Issue Type: Improvement
> Reporter: Qingyou Meng
> Priority: Major
>
> According to the comments from function `set_bits`:
>
> {code:java}
> /// sets all bits on `write_data` on the range
> `[offset_write..offset_write+len]` to be equal to the
> /// bits on `data` on the range `[offset_read..offset_read+len]`{code}
> The function has a defect if `write_data` contains non-null bits: it does not
> unset bits and update the `diff count`. Perhaps should add comment to state
> that `write_data` in range `[offset_write..offset_write+len]` *has been
> zeroed out.*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
