[
https://issues.apache.org/jira/browse/ARROW-11403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Diana Clarke updated ARROW-11403:
---------------------------------
Description:
{{The following commit in version 3.0 accidentally added the options
benchmark-filter and suite-filter to the archery benchmark list command. Those
options aren't applicable to the list command.}}
{{}}
[https://github.com/apache/arrow/commit/1adc7ba5b0dc4fe50ac2347d6b8f8bf426d4b26f]
$ archery benchmark list
Traceback (most recent call last):
File "/Users/diana/envs/pyarrow/bin/archery", line 33, in <module>
sys.exit(load_entry_point('archery', 'console_scripts', 'archery')())
File "/Users/diana/envs/pyarrow/lib/python3.8/site-packages/click/core.py",
line 829, in __call__
return self.main(*args, **kwargs)
File "/Users/diana/envs/pyarrow/lib/python3.8/site-packages/click/core.py",
line 782, in main
rv = self.invoke(ctx)
File "/Users/diana/envs/pyarrow/lib/python3.8/site-packages/click/core.py",
line 1259, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/Users/diana/envs/pyarrow/lib/python3.8/site-packages/click/core.py",
line 1259, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/Users/diana/envs/pyarrow/lib/python3.8/site-packages/click/core.py",
line 1066, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/Users/diana/envs/pyarrow/lib/python3.8/site-packages/click/core.py",
line 610, in invoke
return callback(*args, **kwargs)
File
"/Users/diana/envs/pyarrow/lib/python3.8/site-packages/click/decorators.py",
line 21, in new_func
return f(get_current_context(), *args, **kwargs)
File "/Users/diana/workspace/arrow/dev/archery/archery/cli.py", line 397, in
benchmark_list
conf = CppBenchmarkRunner.default_configuration(
File "/Users/diana/workspace/arrow/dev/archery/archery/benchmark/runner.py",
line 144, in default_configuration
return CppConfiguration(
TypeError: __init__() got an unexpected keyword argument 'benchmark_filter'{{}}
was:
Prior to the following commit in version 3.0, the help for `archery benchmark
list` was as follows.
[https://github.com/apache/arrow/commit/1adc7ba5b0dc4fe50ac2347d6b8f8bf426d4b26f]
{{archery benchmark list --help}}
{{ Usage: archery benchmark list [OPTIONS] [<rev_or_path>]}}{{List benchmark
suite.}}{{Options:}}
\{{ --cmake-extras TEXT Extra flags/options to pass to cmake invocation.}}
\{{ Can be stacked}}{{--output <output> Capture output result into file.}}
\{{ --preserve Preserve workspace for investigation. [default:}}
\{{ False]}}{{--src <arrow_src> Specify Arrow source directory}}
\{{ --cpp-package-prefix TEXT Value to pass for ARROW_PACKAGE_PREFIX and use}}
\{{ ARROW_DEPENDENCY_SOURCE=SYSTEM}}{{--cxx-flags TEXT C++ compiler flags.}}
\{{ --cxx <compiler> C++ compiler.}}
\{{ --cc <compiler> C compiler.}}
\{{ --help Show this message and exit.}}
It has since grown 2 new options that the command doesn't know about.
{{--benchmark-filter <regex> Regex filtering benchmarks.}}
{{--suite-filter <regex> Regex filtering benchmark suites.}}
Resulting in the following error when you try to execute `archery benchmark
list`.
{{Traceback (most recent call last):}}{{ File
"/Users/diana/envs/pyarrow/bin/archery", line 33, in <module>}}{{
sys.exit(load_entry_point('archery', 'console_scripts', 'archery')())}}{{ File
"/Users/diana/envs/pyarrow/lib/python3.8/site-packages/click/core.py", line
829, in __call_}} _{{return self.main(*args, **kwargs)}}{{ File
"/Users/diana/envs/pyarrow/lib/python3.8/site-packages/click/core.py", line
782, in main}}{{ rv = self.invoke(ctx)}}{{ File
"/Users/diana/envs/pyarrow/lib/python3.8/site-packages/click/core.py", line
1259, in invoke}}{{ return
_process_result(sub_ctx.command.invoke(sub_ctx))}}{{ File
"/Users/diana/envs/pyarrow/lib/python3.8/site-packages/click/core.py", line
1259, in invoke}}{{ return
_process_result(sub_ctx.command.invoke(sub_ctx))}}{{ File
"/Users/diana/envs/pyarrow/lib/python3.8/site-packages/click/core.py", line
1066, in invoke}}{{ return ctx.invoke(self.callback, **ctx.params)}}{{ File
"/Users/diana/envs/pyarrow/lib/python3.8/site-packages/click/core.py", line
610, in invoke}}{{ return callback(*args, **kwargs)}}{{ File
"/Users/diana/envs/pyarrow/lib/python3.8/site-packages/click/decorators.py",
line 21, in new_func}}{{ return f(get_current_context(), *args,
**kwargs)}}{{ File "/Users/diana/workspace/arrow/dev/archery/archery/cli.py",
line 397, in benchmark_list}}{{ conf =
CppBenchmarkRunner.default_configuration(}}{{ File
"/Users/diana/workspace/arrow/dev/archery/archery/benchmark/runner.py", line
144, in default_configuration}}{{ return CppConfiguration(}}{{TypeError:
__init}}_{{_() got an unexpected keyword argument 'benchmark_filter'}}
> [Developer] archery benchmark list: unexpected keyword argument
> 'benchmark_filter'
> ----------------------------------------------------------------------------------
>
> Key: ARROW-11403
> URL: https://issues.apache.org/jira/browse/ARROW-11403
> Project: Apache Arrow
> Issue Type: Bug
> Components: Developer Tools
> Affects Versions: 3.0.0
> Reporter: Diana Clarke
> Assignee: Diana Clarke
> Priority: Major
>
> {{The following commit in version 3.0 accidentally added the options
> benchmark-filter and suite-filter to the archery benchmark list command.
> Those options aren't applicable to the list command.}}
> {{}}
> [https://github.com/apache/arrow/commit/1adc7ba5b0dc4fe50ac2347d6b8f8bf426d4b26f]
> $ archery benchmark list
> Traceback (most recent call last):
> File "/Users/diana/envs/pyarrow/bin/archery", line 33, in <module>
> sys.exit(load_entry_point('archery', 'console_scripts', 'archery')())
> File "/Users/diana/envs/pyarrow/lib/python3.8/site-packages/click/core.py",
> line 829, in __call__
> return self.main(*args, **kwargs)
> File "/Users/diana/envs/pyarrow/lib/python3.8/site-packages/click/core.py",
> line 782, in main
> rv = self.invoke(ctx)
> File "/Users/diana/envs/pyarrow/lib/python3.8/site-packages/click/core.py",
> line 1259, in invoke
> return _process_result(sub_ctx.command.invoke(sub_ctx))
> File "/Users/diana/envs/pyarrow/lib/python3.8/site-packages/click/core.py",
> line 1259, in invoke
> return _process_result(sub_ctx.command.invoke(sub_ctx))
> File "/Users/diana/envs/pyarrow/lib/python3.8/site-packages/click/core.py",
> line 1066, in invoke
> return ctx.invoke(self.callback, **ctx.params)
> File "/Users/diana/envs/pyarrow/lib/python3.8/site-packages/click/core.py",
> line 610, in invoke
> return callback(*args, **kwargs)
> File
> "/Users/diana/envs/pyarrow/lib/python3.8/site-packages/click/decorators.py",
> line 21, in new_func
> return f(get_current_context(), *args, **kwargs)
> File "/Users/diana/workspace/arrow/dev/archery/archery/cli.py", line 397, in
> benchmark_list
> conf = CppBenchmarkRunner.default_configuration(
> File "/Users/diana/workspace/arrow/dev/archery/archery/benchmark/runner.py",
> line 144, in default_configuration
> return CppConfiguration(
> TypeError: __init__() got an unexpected keyword argument
> 'benchmark_filter'{{}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
