[ 
https://issues.apache.org/jira/browse/ARROW-11796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ian Cook updated ARROW-11796:
-----------------------------
    Description: 
ARROW-11580 makes it straightforward to use vcpkg for dependencies. This has 
been well-tested with *release* builds, but there are some loose ends with 
*debug* builds. vcpkg installs debug libraries for the dependencies, but there 
are some problems linking them when {{-DCMAKE_BUILD_TYPE=DEBUG}}. I was able to 
get a debug build to succeed on Windows with VS 2019 by turning some features 
off
{code:java}
    -DARROW_FLIGHT=OFF ^
    -DARROW_GANDIVA=OFF ^
    -DARROW_WITH_THRIFT=OFF ^
    -DARROW_PARQUET=OFF ^ {code}
but there were linking errors when I turned any of those on. I think some of 
these errors can be resolved by setting additional {{\*\_MSVC\_\*}} 
prefix/suffix variables or by working around limitations of which dependencies 
vcpkg can and cannot install as dynamic link libraries.

I tested this after installing dynamic link libraries with vcpkg and with 
{{-DARROW_DEPENDENCY_USE_SHARED=ON}}. We should also test debug builds with 
static dependencies and on Linux and Mac.

  was:
ARROW-11580 makes it straightforward to use vcpkg for dependencies. This has 
been well-tested with *release* builds, but there are some loose ends with 
*debug* builds. vcpkg installs debug libraries for the dependencies, but there 
are some problems linking them when {{-DCMAKE_BUILD_TYPE=DEBUG}}. I was able to 
get a debug build to succeed on Windows with VS 2019 by turning some features 
off
{code:java}
    -DARROW_FLIGHT=OFF ^
    -DARROW_GANDIVA=OFF ^
    -DARROW_WITH_THRIFT=OFF ^
    -DARROW_PARQUET=OFF ^ {code}
but there were linking errors when I turned any of those on. I think some of 
these errors can be resolved by setting additional {{*_MSVC_*}} prefix/suffix 
variables or by working around limitations of which dependencies vcpkg can and 
cannot install as dynamic link libraries.

I tested this after installing dynamic link libraries with vcpkg and with 
{{-DARROW_DEPENDENCY_USE_SHARED=ON}}. We should also test debug builds with 
static dependencies and on Linux and Mac.


> [C++] Test, fix, and document debug builds with vcpkg packages
> --------------------------------------------------------------
>
>                 Key: ARROW-11796
>                 URL: https://issues.apache.org/jira/browse/ARROW-11796
>             Project: Apache Arrow
>          Issue Type: Task
>          Components: C++
>            Reporter: Ian Cook
>            Assignee: Ian Cook
>            Priority: Major
>
> ARROW-11580 makes it straightforward to use vcpkg for dependencies. This has 
> been well-tested with *release* builds, but there are some loose ends with 
> *debug* builds. vcpkg installs debug libraries for the dependencies, but 
> there are some problems linking them when {{-DCMAKE_BUILD_TYPE=DEBUG}}. I was 
> able to get a debug build to succeed on Windows with VS 2019 by turning some 
> features off
> {code:java}
>     -DARROW_FLIGHT=OFF ^
>     -DARROW_GANDIVA=OFF ^
>     -DARROW_WITH_THRIFT=OFF ^
>     -DARROW_PARQUET=OFF ^ {code}
> but there were linking errors when I turned any of those on. I think some of 
> these errors can be resolved by setting additional {{\*\_MSVC\_\*}} 
> prefix/suffix variables or by working around limitations of which 
> dependencies vcpkg can and cannot install as dynamic link libraries.
> I tested this after installing dynamic link libraries with vcpkg and with 
> {{-DARROW_DEPENDENCY_USE_SHARED=ON}}. We should also test debug builds with 
> static dependencies and on Linux and Mac.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to