[ 
https://issues.apache.org/jira/browse/ARROW-11752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17314052#comment-17314052
 ] 

Jonathan Keane commented on ARROW-11752:
----------------------------------------

Many (though not all!) of our uses are testing our own R6 class objects which 
isn't totally obvious how to test. 
https://github.com/r-lib/testthat/issues/1271 suggests using 
{{expect_s3_class(object, "R6classname")}} We could (and probably should to 
match the accepted wisdom?) do that. We could also write our own helper 
something like {{expect_r6_class}} that uses {{expect_s3_class}} and then also 
checks that the object is _also_ an R6 object.

> [R] Replace usage of testthat::expect_is()
> ------------------------------------------
>
>                 Key: ARROW-11752
>                 URL: https://issues.apache.org/jira/browse/ARROW-11752
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: R
>            Reporter: Neal Richardson
>            Priority: Minor
>             Fix For: 5.0.0
>
>
> Per https://testthat.r-lib.org/reference/expect_is.html it has been 
> superceded. We have ~180 instances of it in our tests that should be upgraded.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to