[
https://issues.apache.org/jira/browse/ARROW-12240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331740#comment-17331740
]
Yibo Cai commented on ARROW-12240:
----------------------------------
Looks CSV options must be persistent by pickle. [This
test|https://github.com/apache/arrow/blob/ca83a14e264d00c6b4b29560cc2816c6718f52e7/python/pyarrow/tests/test_dataset.py#L617]
crashes after changing the embedded cython struct (CCSVConvertOptions) to
unique_ptr. The loaded pointer is invalid. See CI failure from [PR
10154|https://github.com/apache/arrow/pull/10154].
> [Python] invalid-offsetof warning from apple clang-12
> -----------------------------------------------------
>
> Key: ARROW-12240
> URL: https://issues.apache.org/jira/browse/ARROW-12240
> Project: Apache Arrow
> Issue Type: Bug
> Components: Python
> Reporter: Yibo Cai
> Assignee: Yibo Cai
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Similar issue as https://issues.apache.org/jira/browse/ARROW-11299.
> Found when building pyarrow on Macos M1. I don't think it's platform related.
> No warning for clang-9, but apple clang-12 complains about it.
> Error log:
> {code:bash}
> [ 13%] Building CXX object CMakeFiles/_csv.dir/_csv.cpp.o
> /Users/cyb/work/arrow/python/build/temp.macosx-11.0-arm64-3.9/_csv.cpp:19051:133:
> warning: offset of on non-standard-layout type 'struct
> __pyx_obj_7pyarrow_4_csv_ConvertOptions' [-Winvalid-offsetof]
> if (__pyx_type_7pyarrow_4_csv_ConvertOptions.tp_weaklistoffset == 0)
> __pyx_type_7pyarrow_4_csv_ConvertOptions.tp_weaklistoffset = offsetof(struct
> __pyx_obj_7pyarrow_4_csv_ConvertOptions, __pyx_base.__weakref__);
> ^ ~~~~~~~~~~
> /Library/Developer/CommandLineTools/usr/lib/clang/12.0.0/include/stddef.h:104:24:
> note: expanded from macro 'offsetof'
> #define offsetof(t, d) __builtin_offsetof(t, d)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
