[
https://issues.apache.org/jira/browse/ARROW-10975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17332172#comment-17332172
]
Andrew Lamb commented on ARROW-10975:
-------------------------------------
Migrated to github: https://github.com/apache/arrow-rs/issues/144
> [Rust] Document use of unsafe in IPC
> ------------------------------------
>
> Key: ARROW-10975
> URL: https://issues.apache.org/jira/browse/ARROW-10975
> Project: Apache Arrow
> Issue Type: Sub-task
> Components: Rust
> Reporter: Andy Grove
> Priority: Major
>
> There are ~6 uses of unsafe in IPC and we should document them according to
> the guidelines in the Arrow crate README
>
> {code:java}
> // JUSTIFICATION
> // Benefit
> // Describe the benefit of using unsafe. E.g.
> // "30% performance degradation if the safe counterpart is used, see
> bench X."
> // Soundness
> // Describe why the code remains sound (according to the definition of
> rust's unsafe code guidelines). E.g.
> // "We bounded check these values at initialization and the array is
> immutable."
> let ... = unsafe { ... }; {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
