[ 
https://issues.apache.org/jira/browse/ARROW-12707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342575#comment-17342575
 ] 

Nic Crane commented on ARROW-12707:
-----------------------------------

[~rokm] That's a good question and I think the answer is that there isn't a 
good default value for `pattern`.  The reason this ticket got created was that 
I was implementing R bindings for this, and in the code for other similar 
bindings, we set their options to the defaults if the user doesn't supply any 
values for them.  In this case though, I think that `pattern` should be 
mandatory to be set manually.

Just wondering - is it consistent that `pattern` is an option argument or could 
a case be made for it being a second input like `filter` and `take` have?

> [C++] Add defaults() method  for arrow::compute::SplitPatternOptions
> --------------------------------------------------------------------
>
>                 Key: ARROW-12707
>                 URL: https://issues.apache.org/jira/browse/ARROW-12707
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Nic Crane
>            Priority: Minor
>
> Many of the compute function options objects have a defaults() method in 
> order to initialise the default options.  However, SplitPatternOptions does 
> not. Please can we have one added?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to