[ 
https://issues.apache.org/jira/browse/ARROW-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350497#comment-17350497
 ] 

David Li commented on ARROW-12859:
----------------------------------

Ok, it looks like we don't even have ScalarFromJSON. Let's just add that and 
defer any other changes - just having that should simplify things somewhat 
already (e.g. in a type-parameterized test you can just define a 
{{scalar(string_view)}} helper).

> [C++] Add DatumFromJSON for easier testing
> ------------------------------------------
>
>                 Key: ARROW-12859
>                 URL: https://issues.apache.org/jira/browse/ARROW-12859
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: David Li
>            Assignee: David Li
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> For kernels that accept/return permutations of array/scalar arguments, having 
> a single DatumFromJSON would make things much easier to test (as then we can 
> have helper test methods that just take {{const std::string&}} instead of 
> having to make many overloads for the various input/output permutations).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to